-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore]: Technical: Isolate reducers #1961
Conversation
10df31e
to
22ecbb8
Compare
src/components/map-container.tsx
Outdated
@@ -67,15 +67,15 @@ import ErrorBoundary from 'components/common/error-boundary'; | |||
import {LOCALE_CODES} from '@kepler.gl/localization'; | |||
import {getMapLayersFromSplitMaps, onViewPortChange} from '@kepler.gl/utils'; | |||
import {MapView} from '@deck.gl/core'; | |||
import {MapStyle} from 'reducers'; | |||
import {MapStyle} from '@kepler.gl/reducers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge with line 72
@@ -0,0 +1,38 @@ | |||
# Upgrade Guide (Data Containers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this file moved?
@@ -51,10 +51,10 @@ import { | |||
} from '@kepler.gl/constants'; | |||
import {ExportFileToCloudPayload} from '@kepler.gl/types'; | |||
|
|||
import {FILE_CONFLICT_MSG} from '../cloud-providers'; | |||
import {FILE_CONFLICT_MSG} from 'cloud-providers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge with lint 57
@@ -28,9 +28,9 @@ import {console as Console} from 'global/window'; | |||
|
|||
import {withState, injectComponents, PanelHeaderFactory} from 'components'; | |||
|
|||
import {keplerGlReducerCore as coreReducer} from 'reducers'; | |||
import {keplerGlReducerCore as coreReducer} from '@kepler.gl/reducers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge with line 33
@@ -21,8 +21,8 @@ | |||
/* eslint-disable max-statements */ | |||
|
|||
import test from 'tape'; | |||
import keplerGlReducer from 'reducers'; | |||
import {addDataToMapUpdater, INITIAL_UI_STATE} from 'reducers'; | |||
import keplerGlReducer from '@kepler.gl/reducers'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge with line below
Signed-off-by: Daria Terekhova <[email protected]>
22ecbb8
to
8edcc28
Compare
Signed-off-by: Daria Terekhova <[email protected]>
Signed-off-by: Daria Terekhova [email protected]