Fix screenshot with images #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Zak <[email protected]>
zakjan
force-pushed
the
zakjan/screenshot-images
branch
from
1ebe774
to
9db3b8a
Compare
heshan0131
approved these changes
Jul 23, 2021
lixun910
pushed a commit
to lixun910/kepler.gl
that referenced
this pull request
Aug 13, 2021
Signed-off-by: Jan Zak <[email protected]> Signed-off-by: Xun Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If map component contains images, they should be inlined as in the original dom-to-image. Only data URLs can be skipped. https://github.com/tsayen/dom-to-image/blob/master/src/dom-to-image.js#L718
The bug was introduced in 2bb3867#diff-32702aff9a757e2662e92aab458e2f00268c2397a3046ec69701aa6a99ad3db3L827 (expand the diff of src/utils/dom-to-image.js to see it)