[Feat] Using tippy for map popover #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using Tippy to avoid complex positioning calculations. Hopefully, this will also prevent React RangeError: Maximum call stack size exceeded from happening. (BTW, I was wrong, Tippy does expose Popper's virtual element functionality, but under a different name: [getReferenceClientRect](https://atomiks.github.io/tippyjs/v6/all-props/#getreferenceclientrect), so I could use it here). Tried to keep the current tooltip behavior mostly unchanged - A bit of a clean up of the display logic in `MapContainer` - Tooltip positioning and overflow prevention now takes the boundaries of the container into account (`DeckGL` element) - Improve CSS styling: - using Flexbox instead of absolute positioning for the header row - setting margins _between_ the children of the containers instead of before the individual child elements (using `& > *+* { margin-top: ...}`) - using CSS grid for the tables - we can specify `row-gap` and `column-gap` and avoid outer padding for the content of the cells. This way the content can be correctly aligned with the text outside of the table
ilyabo
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapContainerDeckGLelement)& > *+* { margin-top: ...})row-gapandcolumn-gapand avoid outer padding for the content of the cells. This way the content can be correctly aligned with the text outside of the table