[Feat] Duplicate layer and add layer from config #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyabo
reviewed
Jan 26, 2021
src/reducers/vis-state-updaters.js
Outdated
| @@ -896,6 +898,7 @@ export const removeFilterUpdater = (state, action) => { | |||
| */ | |||
| export const addLayerUpdater = (state, action) => { | |||
| const defaultDataset = Object.keys(state.datasets)[0]; | |||
| if (props.type && state.layerClasses[props.type]) | |||
There was a problem hiding this comment.
This doesn't look right. Was this line added by mistake?
ilyabo
reviewed
Jan 26, 2021
src/reducers/vis-state-updaters.js
Outdated
| let newLabel = `Copy of ${original.config.label}`; | ||
| let postfix = 0; | ||
| while (layers.find(l => l.config.label === newLabel)) { | ||
| newLabel = `${newLabel} ${postfix++}`; |
There was a problem hiding this comment.
This will probably generate something like Copy of My layer 0 1 2 3 4 5 6 and so on: starting with 0 and appending the next number to it every time. It'd be better to define some kind of template in a separate constant like Copy of ${layerName}${postfix} and then replace the variables in the loop.
heshan0131
changed the title
Signed-off-by: Valentine <[email protected]>
Signed-off-by: Valentine <[email protected]>
Signed-off-by: Valentine <[email protected]>
Signed-off-by: Valentine <[email protected]>
Signed-off-by: Shan He <[email protected]>
Signed-off-by: Shan He <[email protected]>
Signed-off-by: Shan He <[email protected]>
heshan0131
force-pushed
the
1224-duplicate-layer
branch
from
e7f7f94 to
35e5d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.