Enable modal types #1 of 2 #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ib Green <[email protected]>
ibgreen
commented
Jul 14, 2020
| <div className="description" /> | ||
| <div className="selection"> | ||
| <FormattedMessage id={'modal.exportMap.html.selection'} /> | ||
| const ExportHtmlMapUnmemoized = ({ |
There was a problem hiding this comment.
Code not changed, just broken out.
ibgreen
commented
Jul 14, 2020
| @@ -44,65 +44,76 @@ const NO_OP = () => {}; | |||
| ExportMapModalFactory.deps = [ExportHtmlMapFactory, ExportJsonMapFactory]; | |||
|
|
|||
| function ExportMapModalFactory(ExportHtmlMap, ExportJsonMap) { | |||
| const ExportMapModal = React.memo( | |||
There was a problem hiding this comment.
Code not changed, just broken out.
heshan0131
reviewed
Jul 14, 2020
| @@ -67,8 +67,26 @@ const StyledImagePreview = styled.div.attrs({ | |||
| } | |||
| `; | |||
|
|
|||
| const ImagePreview = ({exportImage = {}, width = 400, showDimension}) => { | |||
| const {error, imageDataUri, exporting, imageSize: {imageW, imageH} = {}} = exportImage; | |||
| /** @typedef {{ | |||
There was a problem hiding this comment.
ExportImage is defined in ui-state-updater.d.ts
There was a problem hiding this comment.
Great. Will update to use that in #1190
heshan0131
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets type checking flowing through the big modal-container component all the way to
upload-file.js.A few files look like they have big changes but I am just splitting out unmemoized components from memoized ones to ensure typescript can infer the types automatically.