[Feat] add zoom to coordinate tooltip #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shan He <[email protected]>
heshan0131
changed the title
ibgreen
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
I think it may be reasonable to reduce the precision of the zoom (3rd coordinate) to one or two decimals. It does not need as many decimals of precision as the lng/lats do.
Admitting that I didn't read the title of the PR before I started reviewing (my eyes were attracted to the screen shots) I was convinced this new coordinate value represented elevation (meters) until I actually looked into the code and saw that it was zoom.
It may be clearer when mousing around, but I am not sure all users are intuitively familiar with zoom levels and I think this could potentially be confusing unless some additional info is provided (and I guess we can't have hover info inside a hover tooltip).
Signed-off-by: Shan He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tooltip with object hover info
tooltip with only coordinate
Signed-off-by: Shan He [email protected]