[Enhancement] Improve animation sliders #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
heshan0131
commented
Jun 18, 2020
heshan0131
commented
- manage slider animation using animation controller
- improve how handling slider drag event is handled
- support animation by preset interval and time steps
Signed-off-by: Shan He <[email protected]>
Signed-off-by: Shan He <[email protected]>
Signed-off-by: Shan He <[email protected]>
Signed-off-by: Shan He <[email protected]>
heshan0131
force-pushed
the
improve-sliders
branch
from
1736a92 to
7c01c67
Compare
Signed-off-by: Shan He <[email protected]>
Signed-off-by: Shan He <[email protected]>
examples/demo-app/src/app.js
Outdated
| @@ -178,7 +178,7 @@ class App extends Component { | |||
| _loadSampleData() { | |||
| this._loadPointData(); | |||
| // this._loadGeojsonData(); | |||
| // this._loadTripGeoJson(); | |||
| this._loadTripGeoJson(); | |||
There was a problem hiding this comment.
do you want to keep both datasets?
|
|
||
| _timer = null; | ||
|
|
||
| _animte = delay => { |
There was a problem hiding this comment.
did you mean animate? maybe a typo
macrigiuseppe
approved these changes
Jul 3, 2020
Signed-off-by: Shan He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.