Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature: Allow Picking Colors from Local Files #97

Closed
kluhman opened this issue Nov 2, 2016 · 2 comments
Closed

New Feature: Allow Picking Colors from Local Files #97

kluhman opened this issue Nov 2, 2016 · 2 comments
Labels
type: idea Feature requests
Milestone
maybe

Comments

@kluhman
Copy link

kluhman commented Nov 2, 2016

For example, when a PDF is opened in the browser, it would be great to pick a color from that.
@kepi kepi added the type: idea Feature requests label Nov 2, 2016
@kepi
Copy link
Owner

kepi commented Nov 2, 2016

I will probably never implement this feature but I'll leave it here for now, maybe some day.

Problem is that Google doesn't allow extensions by default to interact with local pages. If you want to do so, extension must be reviewed every time there is new version manually and it makes releasing new versions slow and painful.

@kepi kepi added this to the some day milestone Nov 26, 2017
kepi added a commit that referenced this issue Mar 22, 2021
@kepi
Enable access to Local Files if permitted. See #97, #154
501088d 
Thanks to @rc-nbsimmons report in #154 I find out that it is really possible to
manually allow extension to access local files.

This commit enables it while there is new help page explaining how to do this at
https://eyedropper.org/help/file-urls
@kepi
Copy link
Owner

kepi commented Mar 22, 2021

And here comes the never :)

Picking colors from local files is now possible in latest version (0.5.7).

@kepi kepi closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: idea Feature requests
Projects
None yet
Milestone
maybe
Development

No branches or pull requests
2 participants
@kepi @kluhman