Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happens when I select 'pick color from webpage' #255

Closed
NeonBeacon opened this issue Jun 24, 2024 · 7 comments
Closed

Nothing happens when I select 'pick color from webpage' #255

NeonBeacon opened this issue Jun 24, 2024 · 7 comments
Assignees
Labels
comp: picker Picking colors from web pages fixed-in-next This issue will be fixed when next version is published. impact: critical type: bug Bug reports
Milestone

Comments

@NeonBeacon
Copy link

Describe the bug

When I select 'pick color from webpage', it looks to be loading something, but nothing happens and I cannot select any colors.

Expected Behavior

It should show crosshairs cursor when the buitton is selected, however all it does is show a loading sign next to the arrow cursor but nothing happens past that.

Steps To Reproduce

open the extension, select 'pick color from webpage' and hover over the colour you wish to select. Unsure why this does not work for me, I turned all other extensions off in order to see if there was a confliction, but still did not work.

Screenshots

color.picker.not.working.mp4

Operating system

Windows

Browser version

latest

Anything else?

No response

@NeonBeacon NeonBeacon added the type: bug Bug reports label Jun 24, 2024
@kepi
Copy link
Owner

kepi commented Jun 24, 2024

@NeonBeacon thanks for detailed description, this really helps.

I supposed you tried this, but can you please confirm, that you tried to restart the browser? You shouldn't need too, but I just want to be check if problem is in script initialization or elsewhere.

I see from your profile, that you are web developer. If you can work with dev tools, can you please try to check console on the page where you are trying to pick the color and if there is nothing, than try to go to chrome://extensions/ page, turn on developer mode in top right corner and then click on background page link in box with Eye Dropper and check the console there. There might be nothing, but if there are any errors, it will really help to chase this down.

Btw. I'm just finishing big rewrite of Eye Dropper, it should be hopefully published in a few days. If you are, by any chance, interested in alpha/beta testing, let me know.

@NeonBeacon
Copy link
Author

Hi Kepi,

Absolutely, I'm very fresh of the boot(camp), recently changed careers, so could do with all the experience I can get.
Let me know the details and I'll be happy to help out with testing.

Regarding this current issue, yes, I tried rebooting chrome, still nothing, in the console, it shows the below error each time.

(webpage name)':1 Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.'

Seems it just doesn't want to connect for some reason, I've switched VPN off to see if that was the issue, but no dice either.

@kepi
Copy link
Owner

kepi commented Jun 24, 2024

Cool, I'll have to setup some testing group. I'll let you know when I get to it.

Thanks for the error, I hit this while testing the rewritten version once, but wasn't able to reproduce it so far. I'll have to dig deeper. It seems to me like error in Chrome, but hopefully there would be some workaround possible.

@NeonBeacon
Copy link
Author

No problem, look forward to hearing from you Kepi!

Have a good week!

@kepi
Copy link
Owner

kepi commented Jun 24, 2024

Primarily for myself: I think this is a root cause of the problem: https://stackoverflow.com/q/54181734/259187

As changing this code in current version would be dangerous without more testing, I decided against it. This would have to wait for the rewrited version. I made substantial progress today, have all current features reimplemented. Now I just have to polish the interface and test more before releasing.

I'll check if it will be possible to publish alpha version for testing. Last time i tried it, it was rejected by Chrome Store :/

@kepi kepi added impact: critical comp: picker Picking colors from web pages labels Jun 24, 2024
@kepi kepi self-assigned this Jun 24, 2024
@kepi kepi modified the milestones: v0.6.0, v1.2.x.y Jun 24, 2024
@kepi kepi added the fixed-in-next This issue will be fixed when next version is published. label Jul 1, 2024
@kepi
Copy link
Owner

kepi commented Jul 1, 2024

@NeonBeacon folks at Chrome Web Store unfortunatelly takes ages to verify the beta version. If you have time, it would help me if you can test extension from zip file I just published in releases: https://github.com/kepi/chromeEyeDropper/releases/tag/v1.2.0.0

Simply unzip it somewhere, go to chrome://extensions, click on Developer mode top right and then Load unpacked almost top left (below Extension heading).

I'm mostly interested if picking from web page works now, but as this is almost complete rewrite of ED which I would like to publish soon, any feedback is definitely welcomed, even small issues. Feel free to spam here or create new issues if you have time for it :)

Thanks

@kepi kepi mentioned this issue Jul 1, 2024
@NeonBeacon
Copy link
Author

NeonBeacon commented Jul 1, 2024 via email

@kepi kepi closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: picker Picking colors from web pages fixed-in-next This issue will be fixed when next version is published. impact: critical type: bug Bug reports
Projects
None yet
Development

No branches or pull requests

2 participants