Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

girl that is NOT brown #192

Closed
doppioscursedaccount opened this issue Nov 2, 2021 · 1 comment
Closed

girl that is NOT brown #192

doppioscursedaccount opened this issue Nov 2, 2021 · 1 comment
Assignees
@kepi
Labels
comp: popup Generic extension popup issues fixed-in-next This issue will be fixed when next version is published. impact: low type: bug Bug reports
Milestone
v0.5.x bugfixes

Comments

@doppioscursedaccount
Copy link

image
@kepi
Copy link
Owner

kepi commented Nov 2, 2021

I hear ya. It's same trouble as with #b25. That color is totally not #b25, it is just closest short color.

As for named colors - library is guessing closest color, but it would be better to have this clearly separated. Option to have exact color names only could be nice too.

Anyway, it might be beneficial to adjust closest color guessing too (this issue should be filled in external library I'm using). Because when talking aproximations, I would guess this more red than brown.

@kepi kepi self-assigned this May 28, 2022
@kepi kepi added the fixed-in-next This issue will be fixed when next version is published. label May 28, 2022
@kepi kepi added this to the v0.5.x bugfixes milestone May 28, 2022
kepi added a commit that referenced this issue May 28, 2022
@kepi
[popup] Popup fixes and TS conversion
b426582 
- convert Popup to TypeScript
  - move imports directly to popup.ts
  - remove groupEnd arguments which are not allowed
  - add some typing fixes
  - allow ES module interop and synthetic imports in tsconfig
  - remove splitChunks which is breaking output currently
- replace non-maintained pusher.color.js with tinycolor
- remove unused code
- do not display color name and hex3 when there is no exact match: Fixes #192
@kepi kepi added type: bug Bug reports comp: popup Generic extension popup issues labels May 28, 2022
@kepi kepi closed this as completed in 6550ecc May 29, 2022
@kepi kepi mentioned this issue Jun 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kepi kepi

Labels
comp: popup Generic extension popup issues fixed-in-next This issue will be fixed when next version is published. impact: low type: bug Bug reports
Projects
None yet
Milestone
v0.5.x bugfixes
Development

No branches or pull requests
2 participants
@kepi @doppioscursedaccount