Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF thumbnails cannot be right-clicked to open a context menu when Style Settings is enabled #702

Closed
RyotaUshio opened this issue Feb 25, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@RyotaUshio
Copy link

RyotaUshio commented Feb 25, 2024

Is the bug present when using the default Obsidian theme?

No

Is the bug present when snippets and plugins are disabled?

No

Minimal theme version

7.5.1

Describe the bug

When both Minimal & Style Settings are enabled (this is why I answered "No" to the second question), PDF thumbnails cannot be right-clicked to open a context menu.

Screen captures from the sandbox vault:

  • When Minimal & Style Settings are enabled with all the options kept default

    Screen.Recording.2024-02-25.at.16.57.14.mov
  • When Minimal is enabled but Style Settings is disabled

    Screen.Recording.2024-02-25.at.17.00.07.mov
  • When the default theme is used and Style Settings is enabled

    Screen.Recording.2024-02-25.at.17.01.44.mov

Debug info

SYSTEM INFO:
	Obsidian version: v1.5.8
	Installer version: v1.5.3
	Operating system: Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:52 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T8103 22.6.0
	Login status: logged in
	Catalyst license: none
	Insider build toggle: off
	Live preview: on
	Base theme: adapt to system
	Community theme: Minimal v7.5.1
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 1
	Plugins enabled: 1
		1: Style Settings v1.0.7

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
@RyotaUshio RyotaUshio added the bug Something isn't working label Feb 25, 2024
@RyotaUshio RyotaUshio changed the title PDF thumbnails cannot be right-clicked to open a context menu PDF thumbnails cannot be right-clicked to open a context menu when Style Settings is enabled Feb 25, 2024
@RyotaUshio
Copy link
Author

I noticed that this is not specific to PDF thumbnails but applies to all images.
But for images embedded in markdown files, it is not a big deal because Obsidian doesn't show context menus by default.
However, it IS problematic when it comes to PDF thumbnails because right-clicking should trigger a context menu (copy link to page).

kepano added a commit that referenced this issue Feb 25, 2024
@kepano
Copy link
Owner

kepano commented Feb 25, 2024

Fixed in 7.5.2

@kepano kepano closed this as completed Feb 25, 2024
@RyotaUshio
Copy link
Author

Thank you for the quick work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants