Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligns slides in the center #2966

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Conversation

corvus-007
Copy link
Contributor

Aligns slides in the center if the number of slides is less than slidesToShow.
https://codepen.io/corvus-007/pen/LLdPqx?editors=1100

@tkuther
Copy link

tkuther commented Jul 4, 2017

Looks related to #1901

@leggomuhgreggo
Copy link
Collaborator

Couldn't think of any instance where this'd mess things up. Looked good in my testing. My only hesitancy is adding styles that might (in some unknown case) conflict, entropy yada yada, but it's the theme file which is optional, so I'm going to green light it.

Thanks for the PR

@leggomuhgreggo leggomuhgreggo merged commit fda50ab into kenwheeler:master Jul 27, 2017
@mfeltscher
Copy link

This breaks existing setups with centerMode: false and a small number of slides which should be left aligned.

@DanielRuf
Copy link

This breaks existing setups with centerMode: false and a small number of slides which should be left aligned.

Exactly. Also by default this was not centered before so this is a breaking change.

@warudin
Copy link

warudin commented Aug 30, 2017

Since 1.7 sliders with a small number of slides are lined out in the center, but in various cases this isn't the desired effect. What setting do I use to prevent this?

@DanielRuf
Copy link

Since 1.7 sliders with a small number of slides are lined out in the center, but in various cases this isn't the desired effect. What setting do I use to prevent this?

You have to reset the margins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants