Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not limiting Slick children to visible tags. #1353

Closed
andrew-rival opened this issue May 15, 2015 · 3 comments · Fixed by #1357
Closed

Not limiting Slick children to visible tags. #1353

andrew-rival opened this issue May 15, 2015 · 3 comments · Fixed by #1357
Assignees
@simeydotme
Labels
Bug: Confirmed

Comments

@andrew-rival
Copy link

https://github.com/kenwheeler/slick/blob/master/slick/slick.js#L491-L493 is checking against slick-cloned, but it's ignoring the options.slide setting.

Fixed in https://jsfiddle.net/simeydotme/50kp465g/2/ but not regression tested.
@simeydotme simeydotme self-assigned this May 15, 2015
@simeydotme
Copy link
Collaborator

Hmmm, here's the commit where it happened:
9d13d6a#diff-eaaa72f2e5f1d4974e4f1ae902717908L476

.. @kenwheeler was this a mistake, or do you remember why the _.options.slide was removed from the buildOut method (the highlighted line) ? 😕

simeydotme added a commit to simeydotme/slick that referenced this issue May 17, 2015
@simeydotme
Fixing kenwheeler#1353 by filtering the slides in buildOut()
4cb512a 
This filter was removed at
kenwheeler@9d13d6a#diff-eaaa72f2e5f1d4974e4f1ae902717908L476
for some reason, I cannot figure out why. Since it was removed, filtering
slides was not working on initialization.

Tested against Init.
Tested against setOption.
Tested against breakpoints.

Fixes kenwheeler#1353
@simeydotme simeydotme mentioned this issue May 17, 2015
Merged
@cansozeri
Copy link

If you remove _.options.slide + the custom arrows are not work as expected ..
#1204

@simeydotme
Copy link
Collaborator

👍 thanks for adding your issue for reference, @cansozeri ! :)

@simeydotme simeydotme mentioned this issue May 24, 2015
Closed
simeydotme added a commit to simeydotme/slick that referenced this issue Jul 11, 2015
@simeydotme
Merge master with my PRs
22b75a2 
Merge branches:
  - bugfix-327
  - enhancement-1244
  - bugfix-1353

Also added in some aria-attributes based on the recent merged branch kenwheeler#1467
by @msrafi :)

fixes kenwheeler#327, kenwheeler#1244, kenwheeler#1353, kenwheeler#1517, kenwheeler#907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeydotme simeydotme

Labels
Bug: Confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing #1353 by filtering the slides in buildOut() simeydotme/slick
4 participants
@kenwheeler @simeydotme @andrew-rival @cansozeri