feat(items): add support for arrays #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit you can now specify an array of items to rank and those items will be checked individually (before, they were joined with a comma via toString, which is sub optimal).
|
LGTM |
|
Also, it looks like lgtm.co is working now! 🎉 |
Current coverage is 100% (diff: 100%)@@ master #7 diff @@
===================================
Files 1 1
Lines 72 73 +1
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 72 73 +1
Misses 0 0
Partials 0 0
|
|
@kentcdodds looks good to me! This is a pretty cool feature! |
| {favoriteIceCream: ['mint', 'chocolate']}, | ||
| ], | ||
| }, | ||
| 'when using arrays of values, when things are equal, the one with the higher index wins': { |
There was a problem hiding this comment.
This kinda just fell out of the implementation. Pretty solid actually 👍
|
Thanks @conorhastings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit you can now specify an array of items to rank and those items will be checked individually (before, they were joined with a comma via toString, which is sub optimal).
@conorhastings, I need this for what I'm working on right now, so if you could review this really quick that'd be awesome. If you don't have time no worries. I'll probably not need it for an hour. If you don't get to it I'll just merge it myself :)