Add ability to set a threshold per key #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kentcdodds
reviewed
Aug 29, 2018
src/index.js
Outdated
| @@ -60,17 +65,21 @@ function matchSorter(items, value, options = {}) { | |||
| * @param {Array} keys - the keys to get values from the item for the ranking | |||
| * @param {String} value - the value to rank against | |||
| * @param {Object} options - options to control the ranking | |||
| * @return {{rank: Number, keyIndex: Number}} - the highest ranking | |||
| * @return {{rank: Number, keyIndex: Number, itemThreshold: Number}} - the highest ranking | |||
There was a problem hiding this comment.
Should we call this keyThreshold instead?
There was a problem hiding this comment.
Yup. Agree. I’ll make the change soon.
rename itemThreshold to keyThreshold
this way it’ll match a key when the keyThreshold is lower than the default threshold
tikotzky
force-pushed
the
add-key-threshold
branch
from
f65b6bd
to
7c04205
Compare
|
I update the variable name to I also added another test to assert that it will match a key when the keys threshold is set lower that the default threshold |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add the ability to set a threshold per key
Why:
To be able to set specific keys to only match when they meet a specified threshold
How:
By adding returning the keys threshold with each match and verifying that the the match is
>=the threshold specified on its key.Checklist: