Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 TypeError #117

Merged
merged 2 commits into from
Dec 6, 2020
Merged

fix: 🐛 TypeError #117

merged 2 commits into from
Dec 6, 2020

Conversation

PhilGarb
Copy link
Contributor

@PhilGarb PhilGarb commented Dec 5, 2020

What: Fix Type Error

Why: Please see issue for a description of this pull request. => #116

How: When providing keys to the options object the expected type is string. Working with nested arrays in objects does however require mapping over the nested array to produce the strings that should be matched. This fixes a TypeError that expected all the keys to be of type string, by creating a Union Type with type Array.

Checklist:

  • Documentation (this has no public API)
  • Tests
  • Ready to be merged

When providing keys to the options object the expected type is string. Working with nested arrays in objects does however require mapping over the nested array to produce the strings that should be matched. This fixes a TypeError that expected all the keys to be of type string, by creating a Union Type with type Array<string>.

#116
@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #117 (fd36288) into master (e4f32d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          137       137           
  Branches        31        31           
=========================================
  Hits           137       137           
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f32d5...fd36288. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

@kentcdodds kentcdodds merged commit 3a02874 into kentcdodds:master Dec 6, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @PhilGarb for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @PhilGarb! 🎉

@github-actions
Copy link

github-actions bot commented Dec 6, 2020

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants