fix: 🐛 TypeError #117
Merged
fix: 🐛 TypeError #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When providing keys to the options object the expected type is string. Working with nested arrays in objects does however require mapping over the nested array to produce the strings that should be matched. This fixes a TypeError that expected all the keys to be of type string, by creating a Union Type with type Array<string>. #116
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 137 137
Branches 31 31
=========================================
Hits 137 137
Continue to review full report at Codecov.
|
|
@all-contributors please add @PhilGarb for code |
|
I've put up a pull request to add @PhilGarb! 🎉 |
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix Type Error
Why: Please see issue for a description of this pull request. => #116
How: When providing keys to the options object the expected type is string. Working with nested arrays in objects does however require mapping over the nested array to produce the strings that should be matched. This fixes a TypeError that expected all the keys to be of type string, by creating a Union Type with type Array.
Checklist: