Demo is not working #14
Comments
|
Thanks for finding that! It should be working now :) |
|
Ooooh, actually it's not... Looks like something's wrong with the export of the |
kentcdodds
pushed a commit
that referenced
this issue
Aug 31, 2016
Rollup is not capable of exposing a default export AND a named export as a UMD module in a useful way for the global context. So this adds some custom UMD logic to the bottom of the main file. This should hopefully never need to be touched, but there are tests that validate the CJS and ES6 module exports. Things will be challenging when people want to use native ES6 modules with this module (because now we're not exposing this as a native ES6 module). But we weren't really doing that in the first place (we were transpiling) so that's fine for now. Fixes #14
|
@rogeliog, I've filed a PR that should fix these issues. Let me know what you think. |
kentcdodds
pushed a commit
that referenced
this issue
Aug 31, 2016
Rollup is not capable of exposing a default export AND a named export as a UMD module in a useful way for the global context. So this adds some custom UMD logic to the bottom of the main file. This should hopefully never need to be touched, but there are tests that validate the CJS and ES6 module exports. Things will be challenging when people want to use native ES6 modules with this module (because now we're not exposing this as a native ES6 module). But we weren't really doing that in the first place (we were transpiling) so that's fine for now. Fixes #14
kentcdodds
pushed a commit
that referenced
this issue
Aug 31, 2016
Rollup is not capable of exposing a default export AND a named export as a UMD module in a useful way for the global context. So this adds some custom UMD logic to the bottom of the main file. This should hopefully never need to be touched, but there are tests that validate the CJS and ES6 module exports. Things will be challenging when people want to use native ES6 modules with this module (because now we're not exposing this as a native ES6 module). But we weren't really doing that in the first place (we were transpiling) so that's fine for now. Fixes #14
kentcdodds
pushed a commit
that referenced
this issue
Aug 31, 2016
Rollup is not capable of exposing a default export AND a named export as a UMD module in a useful way for the global context. So this adds some custom UMD logic to the bottom of the main file. This should hopefully never need to be touched, but there are tests that validate the CJS and ES6 module exports. Things will be challenging when people want to use native ES6 modules with this module (because now we're not exposing this as a native ES6 module). But we weren't really doing that in the first place (we were transpiling) so that's fine for now. Fixes #14
kentcdodds
pushed a commit
that referenced
this issue
Aug 31, 2016
Rollup is not capable of exposing a default export AND a named export as a UMD module in a useful way for the global context. So this adds some custom UMD logic to the bottom of the main file. This should hopefully never need to be touched, but there are tests that validate the CJS and ES6 module exports. Things will be challenging when people want to use native ES6 modules with this module (because now we're not exposing this as a native ES6 module). But we weren't really doing that in the first place (we were transpiling) so that's fine for now. Fixes #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The demo throws the following error, which happens because the imported
matchSorter.rankingsis undefined.The demo is using
https://npmcdn.com/match-sorter@^1.1.0which needs to be bumped to the latest version and moved fromnpmcdntounpkg.The text was updated successfully, but these errors were encountered: