fix: replace Diactric.js with remove-accents (#58)

Closes #57

BREAKING CHANGE: We changed the diacritics library. No API changes, but there may be some behavioral changes with diacritics.

package.json

@@ -1,8 +1,7 @@
 {
   "name": "match-sorter",
   "version": "0.0.0-semantically-released",
-  "description":
-    "Simple, expected, and deterministic best-match sorting of an array in JavaScript",
+  "description": "Simple, expected, and deterministic best-match sorting of an array in JavaScript",
   "main": "dist/match-sorter.cjs.js",
   "jsnext:main": "dist/match-sorter.esm.js",
   "module": "dist/match-sorter.esm.js",
@@ -19,7 +18,9 @@
     "setup": "npm install && npm run validate",
     "precommit": "kcd-scripts precommit"
   },
-  "files": ["dist"],
+  "files": [
+    "dist"
+  ],
   "keywords": [
     "autocomplete",
     "filter list",
@@ -29,17 +30,25 @@
   ],
   "author": "Kent C. Dodds <[email protected]> (http://kentcdodds.com/)",
   "license": "MIT",
-  "bundledDependencies": ["diacritic"],
+  "bundledDependencies": [
+    "remove-accents"
+  ],
   "dependencies": {
-    "diacritic": "0.0.2"
+    "remove-accents": "0.4.2"
   },
   "devDependencies": {
     "kcd-scripts": "^0.38.1"
   },
   "eslintConfig": {
-    "extends": ["./node_modules/kcd-scripts/eslint.js"]
+    "extends": [
+      "./node_modules/kcd-scripts/eslint.js"
+    ]
   },
-  "eslintIgnore": ["node_modules", "coverage", "dist"],
+  "eslintIgnore": [
+    "node_modules",
+    "coverage",
+    "dist"
+  ],
   "repository": {
     "type": "git",
     "url": "https://github.com/kentcdodds/match-sorter.git"

src/__tests__/index.js

@@ -394,6 +394,10 @@ const tests = {
     ],
     output: [{name: 'Jen', color: 'Red'}],
   },
+  'case insensitive cyrillic match': {
+    input: [['Привет', 'Лед'], 'л'],
+    output: ['Лед'],
+  },
 }
 
 Object.keys(tests).forEach(title => {

src/index.js

@@ -4,7 +4,7 @@
  * @copyright (c) 2017 Kent C. Dodds
  * @author Kent C. Dodds <[email protected]>
  */
-import diacritics from 'diacritic'
+import removeAccents from 'remove-accents'
 
 const rankings = {
   CASE_SENSITIVE_EQUAL: 9,
@@ -366,7 +366,7 @@ function sortRankedItems(a, b) {
 function prepareValueForComparison(value, {keepDiacritics}) {
   value = `${value}` // toString
   if (!keepDiacritics) {
-    value = diacritics.clean(value)
+    value = removeAccents(value)
   }
   return value
 }