This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 245
Windows cross-env example does not work as expected #153
Closed
achingbrain opened this issue
Nov 7, 2017
· 5 comments
· Fixed by m1guelpf/miguelpiedrafita.com#15, mono-js/mono-doc#9 or Yproximite/better-vue-input-tag#34
Closed
Windows cross-env example does not work as expected #153
achingbrain opened this issue
Nov 7, 2017
· 5 comments
· Fixed by m1guelpf/miguelpiedrafita.com#15, mono-js/mono-doc#9 or Yproximite/better-vue-input-tag#34
Comments
I believe you're correct. Thanks for the catch! Could you make a pull request to improve the docs? Thanks! |
Sure, I can submit a PR that removes that section. I'd like to understand why it was there in the first place though - was the expectation that it would work or was it an unimplemented feature or just a bug? |
I think it's a bug. I don't have a windows machine to test things on 😅 |
Me neither, I just fire up VirtualBox with a Windows VM from time to time. |
Yeah, I've got a Windows VM for testing my web app, but I've not taken the time to set it up with git/node/etc. |
achingbrain
added a commit
to achingbrain/cross-env
that referenced
this issue
Nov 15, 2017
achingbrain
added a commit
to achingbrain/cross-env
that referenced
this issue
Dec 7, 2017
After discussion on kentcdodds#155 this seems like the better solution.
This was referenced Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The README has the following example:
If I run this on Windows using cmd.exe I get the following:
That is, it does not interpolate the value of the env var
GREET
. If I change the$GREET
line to%GREET%
inchildScript
, I get the following:Each npm script is run in a subshell (cmd.exe by default on Windows) so I think that's why
$GREET
doesn't work, but the README seems to imply that it should, unless I've got the wrong end of the stick.cross-env
version: 5.1.1node
version: 6.11.3npm
version: 3.10.10The text was updated successfully, but these errors were encountered: