fix: Do not log error message when config is missing #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucleray
changed the title
|
Thank you! I'll try to figure out the build issues. |
|
@all-contributors please add @lucleray for code |
|
I've put up a pull request to add @lucleray! 🎉 |
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
pull bot
pushed a commit
to remaxjs/babel-plugin-macros
that referenced
this pull request
Nov 22, 2019
* Do not log error message when no config is added * update snapshots * update snapshots (bis)
This was referenced Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to only log the following error messages when they need to be logged:
They happen when no config is specified (either in babel or via cosmoconfig). Most babel macros work perfectly well without config so this message is incorrect and the macro itself should throw if the config is missing.
Moreover, the error message states:
Please see the error thrown for more information.but no error is thrown. I've written in this PR what I believe is the expected behavior.Related: