Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination list height is not depends of search bar enable/disable #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kovalskiydmitriy
Copy link

Steps to Reproduce the Problem

  1. Set showSelectedItemsSearch totrue
  2. Choose 8 items in the Source list

Destination list height calculating without search component height.
If showSelectedItemsSearch is true the Destination list height will have no changes, as a result Destination list will have a bug with the displaying last added item.
ScreenCaptureProject75

Proposed Changes

  1. Pass showSelectedItemsSearch prop to DestinationList component to calculate list height in depense on showSelectedItemsSearch true/false
  2. Calculate height of Destination list based on showSelectedItemsSearch true/false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants