Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lockfile to test with new GraphQL core release. #877

Merged
merged 4 commits into from
Jul 7, 2020
Merged

Update lockfile to test with new GraphQL core release. #877

merged 4 commits into from
Jul 7, 2020

Conversation

obi1kenobi
Copy link
Contributor

@obi1kenobi obi1kenobi commented Jul 7, 2020 •
edited
Loading

Just a re-lock to pick up the new graphql-core==3.1.2 release.

@obi1kenobi obi1kenobi added the maintainer quality-of-life Features that ease development, but are not necessarily visible to package users. label Jul 7, 2020
pmantica1
pmantica1 previously approved these changes Jul 7, 2020
View reviewed changes
@obi1kenobi
Copy link
Contributor Author

Yeah, that's what I was worried about. The new @specifiedBy built-in directive breaks our extremely-conservative schema checking.

Fix coming soon.

@LWprogramming LWprogramming mentioned this pull request Jul 7, 2020
Merged
chewselene
chewselene previously approved these changes Jul 7, 2020
View reviewed changes
pmantica1
pmantica1 previously approved these changes Jul 7, 2020
View reviewed changes
@obi1kenobi obi1kenobi dismissed stale reviews from pmantica1 and chewselene via aa3b6f3 July 7, 2020 20:13
pmantica1
pmantica1 previously approved these changes Jul 7, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #877 into main will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   94.79%   94.78%   -0.01%     
==========================================
  Files         108      108              
  Lines        8437     8444       +7     
==========================================
+ Hits         7998     8004       +6     
- Misses        439      440       +1
Impacted Files Coverage Δ
graphql_compiler/compiler/validation.py 100.00% <100.00%> (ø)
...compiler/compiler/ir_lowering_match/ir_lowering.py 95.62% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7b19f...ea7ca74. Read the comment docs.

@pmantica1 pmantica1 merged commit fda23f4 into main Jul 7, 2020
@pmantica1 pmantica1 deleted the use_new_graphql_core branch July 7, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmantica1 pmantica1 pmantica1 approved these changes

@chewselene chewselene chewselene left review comments

@MichaelaShtilmanMinkin MichaelaShtilmanMinkin Awaiting requested review from MichaelaShtilmanMinkin

@bojanserafimov bojanserafimov Awaiting requested review from bojanserafimov

@LWprogramming LWprogramming Awaiting requested review from LWprogramming

Assignees
No one assigned
Labels
maintainer quality-of-life Features that ease development, but are not necessarily visible to package users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obi1kenobi @pmantica1 @chewselene