solve issue 81 #99
Closed
solve issue 81 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test cases written in BackgroundTest.java
kennycason
reviewed
Dec 23, 2021
| * @param alpha The transparent index, should range from 0 to 10 | ||
| * @throws IOException when fails to open file stream | ||
| */ | ||
| public PixelBoundaryBackground(final InputStream imageInputStream, int alpha) throws Exception { |
There was a problem hiding this comment.
I think alpha should just be a 0-255 value instead of clamping it between [0,10].
| int imgHeight = srcImage.getHeight(); | ||
| int imgWidth = srcImage.getWidth(); | ||
| //get the pixel of left upper corner | ||
| int c = srcImage.getRGB(3, 3); |
There was a problem hiding this comment.
I think we should probably pass in an int backgroundColor to the function instead of relying on pixel 3x3 which could be anything.
Sorry for too busy recently, much thanks if you can make the changes and merge them in~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test cases written in BackgroundTest.java