Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Alert Sequence Correction - LoginAdvice Component #1476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ interface Props {
export const LoginAdvice: React.FC<Props> = (props) => {
const loginLink = useLoginLink();

if (props.loading) {
return <Alert color="primary">Loading user info...</Alert>;
}
if (!props.user) {
return (
<Alert color="danger">
<a href={loginLink}>Login</a> to record your progress.
</Alert>
);
}
if (props.loading) {
return <Alert color="primary">Loading user info...</Alert>;
}
if (!props.user.atcoder_user_id) {
return (
<Alert color="warning">
Expand Down