fix: TypeError by is_file()

COMPOSER_PATH may be false. PHP Fatal error: Uncaught TypeError: is_file(): Argument #1 ($filename) must be of type string, bool given in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Autoloader/Autoloader.php:126
kenjis · Dec 9, 2023 · e962fc0 · e962fc0
1 parent e91e5b6
commit e962fc0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/system/Autoloader/Autoloader.php b/system/Autoloader/Autoloader.php
@@ -121,7 +121,7 @@ public function initialize(Autoload $config, Modules $modules)
             $this->helpers = [...$this->helpers, ...$config->helpers];
         }
 
-        if (is_file(COMPOSER_PATH)) {
+        if (COMPOSER_PATH !== false && is_file(COMPOSER_PATH)) {
             $this->loadComposerAutoloader($modules);
         }
 

diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php
@@ -210,7 +210,7 @@ public function initialize()
         Services::exceptions()->initialize();
 
         // Run this check for manual installations
-        if (! is_file(COMPOSER_PATH)) {
+        if (COMPOSER_PATH !== false && ! is_file(COMPOSER_PATH)) {
             $this->resolvePlatformExtensions(); // @codeCoverageIgnore
         }
 

diff --git a/system/Test/bootstrap.php b/system/Test/bootstrap.php
@@ -78,7 +78,7 @@
 Services::autoloader()->loadHelpers();
 
 // Now load Composer's if it's available
-if (is_file(COMPOSER_PATH)) {
+if (COMPOSER_PATH !== false && is_file(COMPOSER_PATH)) {
     require_once COMPOSER_PATH;
 }