fix: is_image causes PHP 8.1 deprecated error

ErrorException : mb_strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated .../CodeIgniter4/system/Validation/FileRules.php:138
kenjis · Jun 19, 2022 · 18f7e8c · 18f7e8c
1 parent 44cbd89
commit 18f7e8c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/system/Validation/FileRules.php b/system/Validation/FileRules.php
@@ -133,7 +133,7 @@ public function is_image(?string $blank, string $params): bool
 
             // We know that our mimes list always has the first mime
             // start with `image` even when then are multiple accepted types.
-            $type = Mimes::guessTypeFromExtension($file->getExtension());
+            $type = Mimes::guessTypeFromExtension($file->getExtension()) ?? '';
 
             if (mb_strpos($type, 'image') !== 0) {
                 return false;

diff --git a/tests/_support/Validation/uploads/abc77tz b/tests/_support/Validation/uploads/abc77tz
diff --git a/tests/system/Validation/FileRulesTest.php b/tests/system/Validation/FileRulesTest.php
@@ -41,7 +41,9 @@ final class FileRulesTest extends CIUnitTestCase
 
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
+
         $this->validation = new Validation((object) $this->config, Services::renderer());
         $this->validation->reset();
 
@@ -229,6 +231,7 @@ public function testIsntImage(): void
             'type'     => 'application/address',
             'error'    => UPLOAD_ERR_OK,
         ];
+
         $this->validation->setRules(['avatar' => 'is_image[stuff]']);
         $this->assertFalse($this->validation->run([]));
     }