fix: TypeError when the field is not sent

TypeError: CodeIgniter\Validation\FormatRules::valid_date(): Argument #1 ($str) must be of type string, null given
kenjis · Mar 16, 2022 · 04e7806 · 04e7806
1 parent 6277232
commit 04e7806
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/system/Validation/FormatRules.php b/system/Validation/FormatRules.php
@@ -333,6 +333,10 @@ public function valid_url_strict(?string $str = null, ?string $validSchemes = nu
      */
     public function valid_date(?string $str = null, ?string $format = null): bool
     {
+        if (($str === null)) {
+            return false;
+        }
+
         if (empty($format)) {
             return strtotime($str) !== false;
         }

diff --git a/tests/system/Validation/FormatRulesTest.php b/tests/system/Validation/FormatRulesTest.php
@@ -1206,6 +1206,11 @@ public function testValidDate(?string $str, ?string $format, bool $expected): vo
     public function validDateProvider(): Generator
     {
         yield from [
+            [
+                null,
+                'Y-m-d',
+                false,
+            ],
             [
                 'Sun',
                 'D',
-Original file line number
+Diff line change
@@ Expand Up @@
         public function validDateProvider(): Generator
         {
             yield from [
+                [
+                    null,
+                    'Y-m-d',
+                    false,
+                ],
                 [
                     'Sun',
                     'D',
@@ Expand Down @@