Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate angular MUI to MDC components #454

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

gsambrotta
Copy link
Collaborator

Related Issue: #446

Step done in this PR:

  • Use Angular Material migration tool to migrate from legacy components to MDC components
  • Fix hover effect bug
  • Fix Form fields without red outline on error
  • Fix Card UI
  • Fix Dialog UI
  • Fix bottom link on /connect page
  • Some clean up and fix indentation

Please reference to Issue #446 to see Before and After screenshot.

Some font style is different, like buttons or some link. We decided to keep the changes that were introduced in Angular Material 16. Please read description and comments on Issue #446 to know more about it.

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kendraio-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 5:52pm

Copy link
Member

@lukestanley lukestanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✨ Nice work investigating and fixing!

@gsambrotta gsambrotta merged commit 6a033ad into angular-16 Mar 4, 2024
3 checks passed
gsambrotta added a commit that referenced this pull request Mar 6, 2024
* migrate with ng generate, fix card style

* adjust dialogs

* fix block comment textarea UI

* clean up main.scss

* fix connect to user link

* update test script with develop, fix datagrid disable test
gsambrotta added a commit that referenced this pull request Jul 31, 2024
* migrate with ng generate, fix card style

* adjust dialogs

* fix block comment textarea UI

* clean up main.scss

* fix connect to user link

* update test script with develop, fix datagrid disable test
gsambrotta added a commit that referenced this pull request Aug 27, 2024
* migrate with ng generate, fix card style

* adjust dialogs

* fix block comment textarea UI

* clean up main.scss

* fix connect to user link

* update test script with develop, fix datagrid disable test
gsambrotta added a commit that referenced this pull request Aug 29, 2024
* migrate with ng generate, fix card style

* adjust dialogs

* fix block comment textarea UI

* clean up main.scss

* fix connect to user link

* update test script with develop, fix datagrid disable test
lukestanley added a commit that referenced this pull request Oct 14, 2024
This reverts commit 36e31d0,
since the commit was found to have an old parent that was introducing unrelated regressions.
lukestanley pushed a commit that referenced this pull request Oct 29, 2024
* migrate with ng generate, fix card style

* adjust dialogs

* fix block comment textarea UI

* clean up main.scss

* fix connect to user link

* update test script with develop, fix datagrid disable test
lukestanley added a commit that referenced this pull request Oct 29, 2024
This reverts commit 36e31d0,
since the commit was found to have an old parent that was introducing unrelated regressions.
lukestanley pushed a commit that referenced this pull request Nov 7, 2024
* migrate with ng generate, fix card style

* adjust dialogs

* fix block comment textarea UI

* clean up main.scss

* fix connect to user link

* update test script with develop, fix datagrid disable test
lukestanley added a commit that referenced this pull request Nov 7, 2024
This reverts commit 36e31d0,
since the commit was found to have an old parent that was introducing unrelated regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants