Check for valid data before loading a schema #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deactivate guard
Updates for file importer
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kendraio/kendraio-app/96ejdKpzjnVWmqo5w5eNyKB1NPQL |
lukestanley
reviewed
Mar 1, 2022
src/app/blocks/load-schema-block/load-schema-block.component.ts
Outdated
Show resolved
Hide resolved
lukestanley
reviewed
Mar 1, 2022
src/app/blocks/rename-fields-block/rename-fields-block.component.ts
Outdated
Show resolved
Hide resolved
lukestanley
requested changes
Mar 1, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I've removed the accidentally added new code to this. We need a better grip on how we are managing schemas in general before creating tests for this block. This is now nothing more than a small big fix to remove an error in mapping code. |
lukestanley
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny fix to check that we have a valid schema Id in place before we attempt to load it.
I've not got a test written for this one. This is essentially a bug fix, so I'm not creating a test for the existence of the bug.