Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify components with broken UI - do they need tests too? #441

Closed
Tracked by #440
lukestanley opened this issue Jan 29, 2024 · 4 comments
Closed
Tracked by #440

Identify components with broken UI - do they need tests too? #441

lukestanley opened this issue Jan 29, 2024 · 4 comments
Labels

Comments

@lukestanley
Copy link
Member

No description provided.

@lukestanley
Copy link
Member Author

@gsambrotta
I was looking at the GitHub Projects demo video and they converted a check list into Issues, I wanted to see if this was possible so I made an issue for Angular 16 and then pasted the list from the Angular 16 PR comment into the top of the issue.
I saw from:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists
"Tip: You cannot create task list items within closed issues or issues with linked pull requests."
So I am concerned, if I like the issue to the PR, suddenly, automatically making issues for it might not work! This seems kinda weird to me, but anyway, I only wanted to test it for now but if you want the check list made into actual issues, see #440.

@gsambrotta
Copy link
Collaborator

gsambrotta commented Feb 5, 2024

@gsambrotta
Copy link
Collaborator

I would close this in favour of #441 which is more complete of the issue to work on after Angular 16 upgrade

@dahacouk
Copy link
Member

@gsambrotta did you mean to say "I would close this in favour of #441" above? As it seems you are referring to itself, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants