Allow running jobs to be stopped #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reimplements resque-status' kill functionality. Using the verb "kill" always seemed like a misnomer since it will not kill a stuck job. Instead we've used the verb "stop" since that's what we're asking the job to do. We've taken some liberties by using the "reserved" field "stop" to implement this functionality. It seemed like a natural fit. Raising `Stopped` also felt like a natural fit. It means the job will not be retried, which is what we want here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements resque-status' kill functionality. Using the verb "kill" always seemed like a misnomer since it will not kill a stuck job.
Instead we've used the verb "stop" since that's what we're asking the job to do. We've taken some liberties by using the "reserved" field "stop" to implement this functionality. It seemed like a natural fit.
Raising
Stoppedalso felt like a natural fit. It means the job will not be retried, which is what we want here.As part of developing this I wanted an easy way to run the specs in docker so I've included a commit that does this too.