Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set split_words:true globally #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option to set split_words:true globally #191

wants to merge 1 commit into from

Conversation

ndrewnee
Copy link

@ndrewnee ndrewnee commented Mar 8, 2021

Closes #190

@vietvudanh
Copy link

Any chance this will be merged? Adding split_words:true everywhere is kind of ridiculous.

@take
Copy link

take commented Oct 14, 2021

@kelseyhightower Hi can you look into this PR? 👀 Thanks!

@ananthb
Copy link

ananthb commented Jan 21, 2022

Also @ndrewnee would you mind adding a MustProcessWithOptions func too?

@ndrewnee
Copy link
Author

Also @ndrewnee would you mind adding a MustProcessWithOptions func too?

I already added it here

@ananthb
Copy link

ananthb commented Jan 25, 2022

Missed it. My bad!

@abhishp
Copy link

abhishp commented Apr 11, 2022

@kelseyhightower any idea if this PR would be merged?

@J0 J0 mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spatecon spatecon spatecon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set split_words as a global option
6 participants
@ndrewnee @vietvudanh @take @ananthb @abhishp @spatecon