fix: py.typed module ignored when building package #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorokithakis
requested changes
Jun 3, 2024
This reverts commit 1214c2b.
maximeflya
commented
Jun 3, 2024
| import sys | ||
|
|
||
| from setuptools import setup | ||
|
|
||
| version_file = "schema.py" | ||
| version_file = os.path.join("schema", "__init__.py") |
There was a problem hiding this comment.
I would prefer using pathlib but for backwards compatibility, os might be better
There was a problem hiding this comment.
Yeah, agreed, especially since it's not much code wasted anyway.
maximeflya
commented
Jun 3, 2024
skorokithakis
approved these changes
Jun 3, 2024
|
Looks good, thanks! Can you please also fix the precommit errors? |
maximeflya
force-pushed
the
fix/update-package-to-include-pytyped-file
branch
from
ce00744
to
f1e42a8
Compare
|
The workflow run did not contain the |
|
Since the linter changed a bunch of things, I'd like to run it myself to verify the changes. I'll hopefully get to it in the next few days, and then merge, thank you! |
|
Merged #319 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #316
Moved from a single module to a package in order for the
py.typedfile to be includedI tested building the package using python 3.8 and installed it. Mypy was able to read the package's types and it works without any code changes.
I manually checked that the
py.typedfile was stored in the wheel and in thetar.gzpackageI ran
pytestin python 3.8 and everything passed