fix for fractional offset (minutes support) #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intcreator
reviewed
Mar 10, 2023
|
|
||
| // remainder of division by 60 | ||
| let remainder = offset - Math.floor(offset); | ||
| const remainderMins = remainder * 60; |
There was a problem hiding this comment.
rather than use a decimal fraction and multiply it by 60, since we already have access to the minutes with this.utcOffset, could you use that to calculate the remaining minutes? like remainderMins = this.utcOffset - (offset * 60)? just to minimize the risk of JS weirdness with decimal fractions
while you're there feel free to use Math.floor(offset) instead of parseInt(offset) and move it above the code you're adding
|
hey thanks for your PR! I added a comment and ran the tests for you |
|
Hi, @intcreator Should I create a new PR for this issue since there has been no activity for a long time? with changes for your comments. |
|
Superseded by #685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #568