Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mangadex: i18n update #6052

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Mangadex: i18n update #6052

wants to merge 1 commit into from

Conversation

NeKoOuO
Copy link

@NeKoOuO NeKoOuO commented Nov 14, 2024 •
edited
Loading

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

AwkwardPeak7
AwkwardPeak7 requested changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@AwkwardPeak7 AwkwardPeak7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to pass the iso_639_1 language code to intl constructor.

also make sure the propeerties file is utf-8 otherwise the characters won't be displayed properly in the app

src/all/mangadex/assets/i18n/messages_zh_tw.properties
set_custom_useragent=設定自訂使用者代理
set_custom_useragent_summary=保留為預設
set_custom_useragent_dialog=\n\n指定自訂使用者代理\n 每次修改後，應用程式需要重新啟動。\n\n預設值：\n%s
set_custom_useragent_error_invalid=無效的使用者代理：%s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set_custom_useragent_error_invalid=無效的使用者代理：%s
set_custom_useragent_error_invalid=無效的使用者代理：%s

newline

@AwkwardPeak7 AwkwardPeak7 marked this pull request as draft November 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AwkwardPeak7 AwkwardPeak7 AwkwardPeak7 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeKoOuO @AwkwardPeak7