fix: Add Sources tab to show all sources of a multi-source app (argop…

…roj#17939) Signed-off-by: Keith Chong <[email protected]>
keithchong · Apr 23, 2024 · 719dc83 · 719dc83
1 parent 56b796d
commit 719dc83
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/ui/src/app/applications/components/application-parameters/application-parameters.tsx b/ui/src/app/applications/components/application-parameters/application-parameters.tsx
@@ -189,10 +189,10 @@ export const ApplicationParameters = (props: {
     } else {
         const v: models.ApplicationSource[] = new Array<models.ApplicationSource>();
         v.push(app.spec.source);
-        return getEditablePanel(attributes, props.details, 0, v);
+        return getEditablePanel(attributes, props.details, 0, v, true);
     }
 
-    function getEditablePanel(panel: EditablePanelItem[], repoAppDetails: models.RepoAppDetails, ind: number, sources: models.ApplicationSource[]): any {
+    function getEditablePanel(panel: EditablePanelItem[], repoAppDetails: models.RepoAppDetails, ind: number, sources: models.ApplicationSource[], isSingleSource?: boolean): any {
         const src: models.ApplicationSource = sources[ind];
         let descriptionCollapsed: string;
         let floatingTitle: string;
@@ -230,18 +230,20 @@ export const ApplicationParameters = (props: {
                 save={
                     props.save &&
                     (async (input: models.Application) => {
+                        const updatedSrc = isSingleSource ? input.spec.source : input.spec.sources[ind];
+
                         function isDefined(item: any) {
                             return item !== null && item !== undefined;
                         }
                         function isDefinedWithVersion(item: any) {
                             return item !== null && item !== undefined && item.match(/:/);
                         }
 
-                        if (src.helm && src.helm.parameters) {
-                            src.helm.parameters = src.helm.parameters.filter(isDefined);
+                        if (updatedSrc.helm && updatedSrc.helm.parameters) {
+                            updatedSrc.helm.parameters = updatedSrc.helm.parameters.filter(isDefined);
                         }
-                        if (src.kustomize && src.kustomize.images) {
-                            src.kustomize.images = src.kustomize.images.filter(isDefinedWithVersion);
+                        if (updatedSrc.kustomize && updatedSrc.kustomize.images) {
+                            updatedSrc.kustomize.images = updatedSrc.kustomize.images.filter(isDefinedWithVersion);
                         }
 
                         let params = input.spec?.source?.plugin?.parameters;