Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Provisioner v2 #83

Merged
merged 41 commits into from
May 9, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 9, 2020

This creates a new provisioner "eks" which uses API calls (vs. cloudformation) to provision the resources.
There are many added features in this provisioner and it is meant to deprecate "eks-cf" provisioner in favor of maintaining this provisioner which is simpler, faster and more reliable.

New features:

custom volumes from spec

  eks:
    configuration:
      volumes:
      - name: /dev/xvda
        type: gp2
        size: 30

taints, labels and tags controlled from spec

  eks:
    configuration:
      tags:
        - key: a-tag
          value: a-value
       labels:
         some-label.kubernetes.io: "true"
       taints:
       - key: node-role.kubernetes.io/some-taint
         value: a-taint
         effect: NoSchedule

basic rolling update:

spec:
  strategy:
    type: rollingUpdate
    rollingUpdate:
      maxUnavailable: 30%

instance group conditions to know when nodes are ready:

  status:
    conditions:
    - status: "True"
      type: NodesReady

are also supported

  • Spot support with minion-manager
  • CRD Strategy

TBD

  • Unit tests
  • BDD test

@eytan-avisror eytan-avisror requested a review from a team as a code owner May 9, 2020 04:57
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          16       16           
  Lines        1697     1697           
=======================================
  Hits         1371     1371           
  Misses        247      247           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab0851...eab0851. Read the comment docs.

@eytan-avisror eytan-avisror mentioned this pull request May 9, 2020
@eytan-avisror eytan-avisror changed the title WIP: v2 EKS Provisioner EKS Provisioner v2 May 9, 2020
@eytan-avisror eytan-avisror merged commit c25989f into keikoproj:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant