Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for existing IAM roles #62

Merged
merged 4 commits into from
Nov 8, 2019

Conversation

eytan-avisror
Copy link
Collaborator

fixes #56

This implements additional configuration for the EKSCF API called roleName which will override the creation of a new IAM role within the cloudformation stack and instead use an existing role for the instance profile + bootstrapping.

This helps with the use case where a user does not wish to create IAM roles from within the cluster and can now provide an externally created IAM role.

In this case the IAM role provided must have the basic minimum roles in order to join the cluster, and managedPolicies field is not supported as the role is now essentially managed by the user and not instance-manager.

Added unit tests

@eytan-avisror eytan-avisror requested a review from a team as a code owner November 7, 2019 20:15
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #62 into master will increase coverage by 0.11%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   72.64%   72.76%   +0.11%     
==========================================
  Files           6        6              
  Lines         797      815      +18     
==========================================
+ Hits          579      593      +14     
- Misses        160      162       +2     
- Partials       58       60       +2
Impacted Files Coverage Δ
...rovisioners/ekscloudformation/ekscloudformation.go 82.44% <100%> (+0.76%) ⬆️
...ollers/provisioners/ekscloudformation/bootstrap.go 81.81% <20%> (-6.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda5afb...9c253dd. Read the comment docs.

Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eytan-avisror eytan-avisror merged commit 51b86e6 into keikoproj:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAM Role pass-through
2 participants