Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD Strategy: implement concurrencyPolicy #6

Merged
merged 6 commits into from
Aug 12, 2019

Conversation

eytan-avisror
Copy link
Collaborator

Fixes #1

  • This implements concurrencyPolicy to lock currently running workflows/CR.
  • Added some doc/example fixes

Testing done

  • Unit tests passing
  • Full bdd test testing
  • Manually ran rollingupgrades with InstanceGroup AMI changes and only a single CR was processed at a time.

@eytan-avisror eytan-avisror added this to the 0.3.0 milestone Aug 12, 2019
@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #6 into master will decrease coverage by 3.13%.
The diff coverage is 53.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   69.37%   66.23%   -3.14%     
==========================================
  Files           5        5              
  Lines         542      616      +74     
==========================================
+ Hits          376      408      +32     
- Misses        122      154      +32     
- Partials       44       54      +10
Impacted Files Coverage Δ
...ontrollers/provisioners/ekscloudformation/types.go 63.07% <50%> (-1.84%) ⬇️
...rollers/provisioners/ekscloudformation/strategy.go 50.81% <52%> (-5.31%) ⬇️
...trollers/provisioners/ekscloudformation/helpers.go 60% <60%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370d88f...4c21651. Read the comment docs.

Copy link
Contributor

@vgunapati vgunapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments.

controllers/provisioners/ekscloudformation/helpers.go Outdated Show resolved Hide resolved
controllers/provisioners/ekscloudformation/strategy.go Outdated Show resolved Hide resolved
@eytan-avisror eytan-avisror requested a review from a team as a code owner August 12, 2019 20:14
@eytan-avisror eytan-avisror merged commit 762c5c9 into keikoproj:master Aug 12, 2019
@eytan-avisror eytan-avisror deleted the crd-strategy-bug branch August 12, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRD Strategy: may fail when multiple spec updates happen during upgrade
4 participants