Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support additional options for rollingUpdate #44

Conversation

eytan-avisror
Copy link
Collaborator

fixes #39

This makes rollingUpdate more usable by making it's options configurable.

@eytan-avisror eytan-avisror requested a review from a team as a code owner September 12, 2019 16:39
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #44 into master will increase coverage by 0.72%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   70.88%   71.61%   +0.72%     
==========================================
  Files           6        6              
  Lines         742      761      +19     
==========================================
+ Hits          526      545      +19     
  Misses        159      159              
  Partials       57       57
Impacted Files Coverage Δ
...rovisioners/ekscloudformation/ekscloudformation.go 80.26% <100%> (+0.06%) ⬆️
...rollers/provisioners/ekscloudformation/strategy.go 56.52% <100%> (+4.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db31492...8d89ddf. Read the comment docs.

@eytan-avisror
Copy link
Collaborator Author

BDDs passed

Ran 4 of 4 Specs in 1259.401 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestE2e (1259.40s)
PASS
ok  	github.com/keikoproj/instance-manager/test-bdd	1259.799s

Copy link
Member

@tekenstam tekenstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although should add documentation for these new options, perhaps in another PR.

@eytan-avisror eytan-avisror merged commit 83b5fc7 into keikoproj:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RollingUpdate: Support additional configuration options
3 participants