Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bdd templates #334

Conversation

preflightsiren
Copy link
Contributor

No description provided.

@preflightsiren preflightsiren requested review from a team as code owners October 13, 2021 09:40
@preflightsiren
Copy link
Contributor Author

@eytan-avisror can you try running the BDD tests with this patch, I'm unable to run the tests at the moment to verify myself, but I'm confident this is the thing missing.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #334 (1fe2f51) into master (165095e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   51.08%   51.08%           
=======================================
  Files          33       33           
  Lines        4504     4504           
=======================================
  Hits         2301     2301           
  Misses       2062     2062           
  Partials      141      141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165095e...1fe2f51. Read the comment docs.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, can you rebase your commit with a signature so DCO is passing?

@preflightsiren
Copy link
Contributor Author

🤦‍♂️ whoops!

Signed-off-by: Sebastian Cole <[email protected]>
@preflightsiren preflightsiren force-pushed the preflightsiren-latest-ami-update branch from c808f7b to 1fe2f51 Compare October 15, 2021 00:54
@preflightsiren
Copy link
Contributor Author

@eytan-avisror done.

@eytan-avisror eytan-avisror merged commit 5215605 into keikoproj:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants