-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AL2 Support for AWS Warm Pools #286
Conversation
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
…into pre-warm Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Support upgrade operation for IGs with warm pool
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 70.19% 70.00% -0.19%
==========================================
Files 19 19
Lines 2979 3094 +115
==========================================
+ Hits 2091 2166 +75
- Misses 758 788 +30
- Partials 130 140 +10
Continue to review full report at Codecov.
|
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
33 scenarios (33 passed)
189 steps (189 passed)
31m12.218033102s
testing: warning: no tests to run
PASS
ok github.com/keikoproj/instance-manager/test-bdd 1872.780s [no tests to run] |
@backjo can you review when you get a chance? |
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Thanks for the review @backjo, I addressed the comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - this is going to be really exciting to use!
Adds to #277
TBD: