Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AL2 Support for AWS Warm Pools #286

Merged
merged 22 commits into from
May 3, 2021

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Apr 30, 2021

Adds to #277

TBD:

  • Unit testing
  • Documentation

Eytan Avisror and others added 8 commits April 26, 2021 16:09
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Support upgrade operation for IGs with warm pool
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror eytan-avisror requested review from a team as code owners April 30, 2021 00:23
eytan-avisror and others added 3 commits April 29, 2021 17:23
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #286 (0fddd04) into master (541ec27) will decrease coverage by 0.18%.
The diff coverage is 65.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   70.19%   70.00%   -0.19%     
==========================================
  Files          19       19              
  Lines        2979     3094     +115     
==========================================
+ Hits         2091     2166      +75     
- Misses        758      788      +30     
- Partials      130      140      +10     
Impacted Files Coverage Δ
api/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
controllers/provisioners/eks/eks.go 88.63% <ø> (ø)
controllers/provisioners/eks/update.go 79.90% <14.28%> (-2.22%) ⬇️
api/v1alpha1/instancegroup_types.go 15.22% <31.81%> (+1.11%) ⬆️
controllers/provisioners/eks/upgrade.go 84.96% <77.27%> (-3.83%) ⬇️
controllers/provisioners/eks/helpers.go 91.37% <91.11%> (-0.02%) ⬇️
controllers/provisioners/config.go 77.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541ec27...0fddd04. Read the comment docs.

Eytan Avisror added 5 commits April 30, 2021 18:25
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror eytan-avisror changed the title WIP: AL2 Support for AWS Warm Pools AL2 Support for AWS Warm Pools May 1, 2021
@eytan-avisror
Copy link
Collaborator Author

33 scenarios (33 passed)
189 steps (189 passed)
31m12.218033102s
testing: warning: no tests to run
PASS
ok  	github.com/keikoproj/instance-manager/test-bdd	1872.780s [no tests to run]

@eytan-avisror
Copy link
Collaborator Author

@backjo can you review when you get a chance?

controllers/provisioners/eks/eks_test.go Outdated Show resolved Hide resolved
docs/EKS.md Show resolved Hide resolved
api/v1alpha1/instancegroup_types.go Outdated Show resolved Hide resolved
controllers/provisioners/eks/helpers.go Outdated Show resolved Hide resolved
Eytan Avisror added 5 commits May 3, 2021 14:00
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror
Copy link
Collaborator Author

Thanks for the review @backjo, I addressed the comments

Copy link
Collaborator

@backjo backjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - this is going to be really exciting to use!

@eytan-avisror eytan-avisror merged commit 503d90c into keikoproj:master May 3, 2021
@eytan-avisror eytan-avisror mentioned this pull request May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants