Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor eks-managed GetLabelsUpdatePayload #276

Merged
merged 3 commits into from
Apr 18, 2021

Conversation

eytan-avisror
Copy link
Collaborator

Signed-off-by: Eytan Avisror [email protected]

fixes #275

@eytan-avisror eytan-avisror requested review from a team as code owners April 18, 2021 05:30
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #276 (09ce259) into master (bb272e3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files          17       17              
  Lines        2319     2318       -1     
==========================================
- Hits         2042     2041       -1     
  Misses        173      173              
  Partials      104      104              
Impacted Files Coverage Δ
controllers/provisioners/eksmanaged/eksmanaged.go 85.00% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb272e3...09ce259. Read the comment docs.

@eytan-avisror
Copy link
Collaborator Author

27 scenarios (27 passed)
147 steps (147 passed)
26m52.530605422s
testing: warning: no tests to run
PASS
ok  	github.com/keikoproj/instance-manager/test-bdd	1612.963s [no tests to run]

@eytan-avisror eytan-avisror merged commit 165312e into keikoproj:master Apr 18, 2021
@eytan-avisror eytan-avisror mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BDD Failure: eks-managed update call is failing
1 participant