fix: bdd cleanup timing bug #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 10, 2021 17:25
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 17 17
Lines 2237 2237
=======================================
Hits 1971 1971
Misses 162 162
Partials 104 104 Continue to review full report at Codecov.
|
Signed-off-by: Eytan Avisror <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if the bdd fails it does not clean up properly by deleting the config map while the instance group is still being deleted - this leaves the controller in a bad state.
This is prevented by leaving the configmap deletion to the very end of deleteAll()
Also added resource kind to logging and made waiter polling interval shorter