fix: remove explicit architecture in go build #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Back <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 17 17
Lines 2188 2188
=======================================
Hits 1929 1929
Misses 159 159
Partials 100 100 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit GOARCH variable in the Dockerfile causes ARM images to contain an AMD64 executable. This variable is unnecessary, since go will inspect the system to figure out what architecture it is running in.
Signed-off-by: Jonah Back [email protected]