Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #222

Merged
merged 7 commits into from
Jan 7, 2021
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Jan 5, 2021

Signed-off-by: Eytan Avisror [email protected]

This updates the following dependencies:

  • Golang 1.13 > 1.14
  • controller-runtime 0.4.0 > 0.7.0
  • client-go 0.17.13 > 0.19.6 (includes refactor)
  • aws-auth 0.2.0 > 0.3.0
  • controller-gen 0.2.9 > 0.4.1

Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror eytan-avisror requested review from a team as code owners January 5, 2021 23:07
Eytan Avisror added 2 commits January 5, 2021 16:07
Signed-off-by: Eytan Avisror <[email protected]>
Signed-off-by: Eytan Avisror <[email protected]>
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #222 (f2b36fb) into master (6a42148) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files          17       17           
  Lines        2188     2188           
=======================================
  Hits         1929     1929           
  Misses        159      159           
  Partials      100      100           
Impacted Files Coverage Δ
controllers/provisioners/eks/cloud.go 84.65% <100.00%> (ø)
controllers/provisioners/eks/helpers.go 90.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a42148...f2b36fb. Read the comment docs.

Signed-off-by: Eytan Avisror <[email protected]>
@eytan-avisror eytan-avisror changed the title Update dependencies for client-go & aws-auth Update dependencies Jan 6, 2021
Signed-off-by: Eytan Avisror <[email protected]>
Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eytan-avisror eytan-avisror merged commit 2b0cd04 into keikoproj:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants