Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle hook support #176

Merged
merged 11 commits into from
Oct 8, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Oct 7, 2020

Fixes #175

TBD:

  • Add unit tests
  • Documentation
  • BDD passing

Eytan Avisror added 2 commits October 6, 2020 21:10
@eytan-avisror eytan-avisror requested review from a team as code owners October 7, 2020 04:34
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #176 into master will decrease coverage by 0.71%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   89.98%   89.26%   -0.72%     
==========================================
  Files          15       15              
  Lines        1717     1612     -105     
==========================================
- Hits         1545     1439     -106     
+ Misses        111      107       -4     
- Partials       61       66       +5     
Impacted Files Coverage Δ
controllers/provisioners/config.go 70.90% <ø> (-3.08%) ⬇️
controllers/provisioners/eks/create.go 93.25% <0.00%> (-2.30%) ⬇️
controllers/provisioners/eks/update.go 91.82% <0.00%> (-1.71%) ⬇️
controllers/provisioners/eks/cloud.go 85.95% <60.00%> (-3.42%) ⬇️
controllers/provisioners/eks/helpers.go 89.21% <90.90%> (-0.34%) ⬇️
controllers/provisioners/eksfargate/types.go 83.33% <0.00%> (-6.67%) ⬇️
controllers/provisioners/eksmanaged/types.go 66.66% <0.00%> (-2.57%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b35f6...cbf763a. Read the comment docs.

Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eytan-avisror eytan-avisror merged commit 6267b16 into keikoproj:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for lifecycle hooks
2 participants