Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add strategy & provisioner to status #171

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

eytan-avisror
Copy link
Collaborator

Fixes #170

Adds strategy & provisioner as status fields so that it's never missing in printer columns when using configmap defaults

@eytan-avisror eytan-avisror requested review from a team as code owners September 16, 2020 17:33
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #171 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   89.96%   89.98%   +0.01%     
==========================================
  Files          15       15              
  Lines        1714     1717       +3     
==========================================
+ Hits         1542     1545       +3     
  Misses        111      111              
  Partials       61       61              
Impacted Files Coverage Δ
controllers/provisioners/eks/eks.go 89.47% <100.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdfe83...ed4cdf1. Read the comment docs.

@eytan-avisror eytan-avisror merged commit e4b35f6 into keikoproj:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printer Columns - when using configmap some values are lost
2 participants