Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Abstract ScalingConfiguration #165

Merged
merged 10 commits into from
Aug 20, 2020

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Aug 18, 2020

Ref #17
Fixes #163

This abstracts the concrete launch configuration state/provisioner into an interface called ScalingConfiguration which can create multiple types of configurations.

Added the implementation of a LaunchConfiguration type and refactored the code & tests to use that instead of existing implementation.

This will allow to create a new ScalingConfiguration type later called LaunchTemplate

  • BDD passing
  • Manual testing

@eytan-avisror eytan-avisror requested review from a team as code owners August 18, 2020 23:06
@eytan-avisror eytan-avisror changed the title Refactor - Abstract ScalingConfiguration WIP: Refactor - Abstract ScalingConfiguration Aug 18, 2020
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #165 into master will increase coverage by 0.50%.
The diff coverage is 96.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   89.41%   89.92%   +0.50%     
==========================================
  Files          13       15       +2     
  Lines        1654     1647       -7     
==========================================
+ Hits         1479     1481       +2     
+ Misses        113      108       -5     
+ Partials       62       58       -4     
Impacted Files Coverage Δ
controllers/provisioners/config.go 73.98% <ø> (-0.21%) ⬇️
controllers/provisioners/eks/state.go 92.85% <ø> (ø)
controllers/provisioners/eksfargate/eksfargate.go 93.91% <ø> (-0.13%) ⬇️
controllers/provisioners/eksmanaged/eksmanaged.go 84.41% <ø> (+2.65%) ⬆️
controllers/provisioners/eks/cloud.go 89.28% <87.50%> (+3.39%) ⬆️
...ntrollers/provisioners/eks/scaling/launchconfig.go 95.30% <95.30%> (ø)
controllers/provisioners/eks/create.go 95.50% <100.00%> (+2.73%) ⬆️
controllers/provisioners/eks/delete.go 96.36% <100.00%> (+0.90%) ⬆️
controllers/provisioners/eks/helpers.go 89.38% <100.00%> (-0.72%) ⬇️
controllers/provisioners/eks/update.go 93.49% <100.00%> (-3.11%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5082305...a2ca7fb. Read the comment docs.

@eytan-avisror eytan-avisror changed the title WIP: Refactor - Abstract ScalingConfiguration Refactor - Abstract ScalingConfiguration Aug 19, 2020
@eytan-avisror eytan-avisror merged commit af5eed1 into keikoproj:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch Templates - Abstract ScalingConfiguration
2 participants