-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor - Abstract ScalingConfiguration #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eytan-avisror
changed the title
Refactor - Abstract ScalingConfiguration
WIP: Refactor - Abstract ScalingConfiguration
Aug 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 89.41% 89.92% +0.50%
==========================================
Files 13 15 +2
Lines 1654 1647 -7
==========================================
+ Hits 1479 1481 +2
+ Misses 113 108 -5
+ Partials 62 58 -4
Continue to review full report at Codecov.
|
eytan-avisror
changed the title
WIP: Refactor - Abstract ScalingConfiguration
Refactor - Abstract ScalingConfiguration
Aug 19, 2020
shrinandj
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #17
Fixes #163
This abstracts the concrete launch configuration state/provisioner into an interface called ScalingConfiguration which can create multiple types of configurations.
Added the implementation of a LaunchConfiguration type and refactored the code & tests to use that instead of existing implementation.
This will allow to create a new ScalingConfiguration type later called LaunchTemplate