Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc & logging fixes #154

Merged

Conversation

eytan-avisror
Copy link
Collaborator

Fixes #150

Logging fixed after adding missing ()

failed to terminate targets	{"reason": "AccessDenied: User: <reducted> is not authorized to perform: autoscaling:TerminateInstanceInAutoScalingGroup on resource:<reducted>\n\tstatus code: 403, request id: 3d1d3fab-e282-42f6-90dc-61699b9397f7", "scalinggroup": "instancemgr-dev-instance-manager-my-instance-group-2", "targets": ["i-025a0d00ddadf24b8"]}

Fixed docs for IAM permissions needed

@eytan-avisror eytan-avisror requested review from a team as code owners July 29, 2020 22:09
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   89.25%   89.25%           
=======================================
  Files          13       13           
  Lines        1563     1563           
=======================================
  Hits         1395     1395           
  Misses        111      111           
  Partials       57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4391015...aa0fb89. Read the comment docs.

@eytan-avisror eytan-avisror merged commit ff2721a into keikoproj:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes are not rotated when image (AMI) is updated
2 participants